grwehner/mdm custom metric regions#471
Merged
gracewehner merged 6 commits intoNov 23, 2020
Merged
Conversation
vishiy
previously approved these changes
Nov 11, 2020
| # Set environment variable for if public cloud by checking the workspace domain. | ||
| if [ -z $domain ]; then | ||
| ClOUD_ENVIRONMENT="unknown" | ||
| elif [ $domain == "opinsights.azure.com" ]; then |
Contributor
There was a problem hiding this comment.
i think as we are starting to add more constants here, we can move the string constants to a file. Not in the scope of this PR. But we can discuss and make the changes later.
rashmichandrashekar
approved these changes
Nov 21, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My questions:
Should the check be more explicit by specifically checking if the workspace domain is indeed for a national cloud? Should custom metrics be available for any other cluster with a workspace domain that isn't opinsights.azure.com? What should the strategy be if the domain is not set?